[vlc-devel] [PATCH] Revert "Switch smbclient detection to pkg-config"

[Zoran Turalija]

On Fri, Mar 29, 2013 at 09:21:02PM +0200, Rémi Denis-Courmont wrote:
> Le vendredi 29 mars 2013 20:05:54, Zoran Turalija a écrit :
> > But, if you just send message - "fix upstream", it wont hide the fact that
> > 783ebff129 commit just broke on logic "don't break something that wasnt
> > broken before."
> 
> It did not break the logic. It cleaned it up *and* it fixed it (since it was 
> indeed broken as Nicolas explained).

Surely you misunderstood me on purpose. Logic I was referring was not computer
one.
 
> > Maybe that is not the motto of this open source project?
> 
> The point of open-source pretty much is that you can modify (including fix) 
> upstream, actually. If you think it is a bug in VLC, you are free to fork VLC 
> and put your fix it. If you think it is a bug in Ubuntu, you are similarly free 
> to get the package sources, fix them and rebuild.

Didnt knew I had to write an essay about this.
I checked that bug was submitetd on feb 18th already:

https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1129110

But, this is USER point of view issue in case of VLC project.
 
> > And it is user unfriendly. For all current Ubuntu/Debian users (excluding
> > Debian experimental/rc-buggy users). And it is clear that commit improved
> > "a lot" how configure detects smbclient; just as clear as it brakes
> > detection for many current users.
> 
> News flash: compiling from source is user-unfriendly.

Maybe in 1995.
 
> > It is a normal thing in open source project to revert commit that broke
> > previous working state. But, ones with power to commit will decide
> > eventually.
> 
> Exposing a (latent) bug is not the same as introducing the bug ("breaking"). 
> The bug was introduced when Debian samba maintainers failed to distribute the 
> pkg-config file.
> 
> There are enough bugs and hacks in VLC to keep us busy; we have better things 
> to do that take care of bugs in other software.

Luckily, this is not the case. It's more like:

...switch distro...
...fix upstream...
...future version "may" brake...

is easier to say. Maybe ego? That is all.

Nevertheless, I don't want to argue. I agree that we disagree.

I retract the patch.

Moving on, keep the good work guys.

-- 
Kind regards,
Zoran Turalija