[vlc-devel] [PATCH] Fix text for stereo-mode variable
remi at remlab.net
Wed May 22 17:15:10 CEST 2013
Le jeudi 16 mai 2013 23:37:37, David Fuhrmann a écrit :
> Attached patch always sets the text for stereo-mode variable, because the
> GUI relies on it for updating its menus. (Otherwise, the GUI prints the
> variable name which is not nice at all.)
> Additionally, I reverted back the text to the old one because it fits
> better IMHO, the old text is already translated and known from VLC 2.0,
> and the new one is not translated yet, probably. I know that we are in
> string freeze already, but IMHO its better to *now* reduce the string
> count in this case, than never, probably.
> Would this be ok for you?
No. stereo-mode covers only stereo inputs. Eventually there should be another
variable to control surround inputs. IOW, this is not about "Audio Channels",
this is about "Audio channels" when (and *only* when) the input is stereo.
And regardless, the patch has capitalization wrong.
More information about the vlc-devel