[vlc-devel] [PATCH] Fix text for stereo-mode variable

David Fuhrmann david.fuhrmann at gmail.com
Wed May 22 21:09:22 CEST 2013


On 22.05.2013, at 17:15, Rémi Denis-Courmont <remi at remlab.net> wrote:

> Le jeudi 16 mai 2013 23:37:37, David Fuhrmann a écrit :
>> Hi,
>> 
>> Attached patch always sets the text for stereo-mode variable, because the
>> GUI relies on it for updating its menus. (Otherwise, the GUI prints the
>> variable name which is not nice at all.)
>> 
>> Additionally, I reverted back the text to the old one because it fits
>> better IMHO, the old text is already translated and known from VLC 2.0,
>> and the new one is not translated yet, probably. I know that we are in
>> string freeze already, but IMHO its better to *now* reduce the string
>> count in this case, than never, probably.
>> 
>> Would this be ok for you?
> 
> No.

Ok, I will revert to the old text.

> And regardless, the patch has capitalization wrong.

The capitalization is right, as all Mac OS interface elements should have this capitalization. Some other variables already have the same capitalization, whereas others have not. As the qt interface has other strings (including the &), anyway, I suggest to also convert the remaining visible variable texts to this capitalization style, later on.

With best regards,
David


More information about the vlc-devel mailing list