[vlc-devel] [vlc-commits] http filters: pause not implemented, pace control not supported

[Rémi Denis-Courmont]

On Fri, 24 May 2013 10:44:35 +0300, Ilkka Ollakka <ileoo at videolan.org>
wrote:
> Hi,
> 
> On Tue, Apr 16, 2013 at 07:20:00PM +0200, Rémi Denis-Courmont wrote:
>> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Apr
>> 16 20:09:07 2013 +0300| [cca4ec23128c29f56382eb99da10c8bf3473680d] |
>> committer: Rémi Denis-Courmont
> 
>> http filters: pause not implemented, pace control not supported
> 
>> Also add missing STREAM_CAN_FASTSEEK to HTTP live.
> 
>> index 4771f79..e51c740 100644
>> --- a/modules/stream_filter/httplive.c
>> +++ b/modules/stream_filter/httplive.c
>> @@ -2493,6 +2493,11 @@ static int Control(stream_t *s, int i_query,
>> va_list args)
>>          case STREAM_CAN_SEEK:
>>              *(va_arg (args, bool *)) = hls_MaySeek(s);
>>              break;
>> +        case STREAM_CAN_FASTSEEK:
>> +        case STREAM_CAN_PAUSE: /* TODO */
>> +        case STREAM_CAN_CONTROL_PACE:
>> +            *(va_arg (args, bool *)) = false;
>> +            break;
>>          case STREAM_GET_POSITION:
>>              *(va_arg (args, uint64_t *)) = p_sys->playback.offset;
> 
> This seems to break http live streams for me. When reverted CAN_PAUSE
> and CAN_CONTROL_PACE to same as CAN_SEEK streams started to work again.

I fail to see the code to deal with pause, and I fail to see how to pace a
live input. Feel free to mark them as supported once they are.

-- 
Rémi Denis-Courmont
Sent from my collocated server