[vlc-devel] [PATCH] build: Undef _FORTIFY_SOURCE before setting it

Luca Barbato lu_zero at gentoo.org
Mon Nov 4 13:48:03 CET 2013


On 03/11/13 19:17, Rémi Denis-Courmont wrote:
> Le dimanche 3 novembre 2013 19:00:38 Luca Barbato a écrit :
>> On 29/09/13 08:32, Luca Barbato wrote:
>>> It is commonly present as part of the compiler defaults in some
>>> distributions.
> 
> Flags that control glibc headers are the responsibility of the application, 
> not the toolchain. This is no different from the other _*_SOURCE macros.
> Otherwise, those things would presumably be compilation time option of glibc 
> (or _compiler_ flags as opposed to _preprocessor_ flags).
> 
> I think you need to fix your packaging rules, more than you need to fix VLC.

By the same logic since we are not checking we are using glibc before
adding it we could drop it completely.

lu



More information about the vlc-devel mailing list