[vlc-devel] [PATCH] build: Drop _FORTIFY_SOURCE definition

[Luca Barbato]

On 05/11/13 14:56, Rémi Denis-Courmont wrote:
> On Tue,  5 Nov 2013 14:51:29 +0100, Luca Barbato <lu_zero at gentoo.org>
> wrote:
>> It is glibc-specific and should be let the user decide what to do
>> about it.
> 
> This is no different than _GNU_SORUCE, _THREAD_SAFE, _REENTRANT and
> _FILE_OFFSET_BITS which we all set.

[1] is either disagreeing with you or outdated.

> They are all under the same category in <features.h>.
> So this patch is completely incoherent, as was the previous one.

The main difference between those symbols and _FORTIFY_SOURCE is that
the latter is completely optional and the users might not care or do
care enough to set it on their own.

[1]
http://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html

Yet again stuff like _REENTRANT gets set by compiler flags and
redefinition warnings are quite annoying and shutting them down by
either adding -U or as the patch you dislike is probably the best for
the poor soul trying to keep the warning count down.

lu