[vlc-devel] [PATCH] build: Drop _FORTIFY_SOURCE definition

[Rémi Denis-Courmont]

On Tue, 05 Nov 2013 15:11:15 +0100, Luca Barbato <lu_zero at gentoo.org>
wrote:
> On 05/11/13 14:56, Rémi Denis-Courmont wrote:
>> On Tue,  5 Nov 2013 14:51:29 +0100, Luca Barbato <lu_zero at gentoo.org>
>> wrote:
>>> It is glibc-specific and should be let the user decide what to do
>>> about it.
>> 
>> This is no different than _GNU_SORUCE, _THREAD_SAFE, _REENTRANT and
>> _FILE_OFFSET_BITS which we all set.
> 
> [1] is either disagreeing with you or outdated.

"You should define these macros by using ‘#define’ preprocessor directives
at the top of your source code files."

"You could also use the ‘-D’ option to GCC, but it's better if you make
the source files indicate their own meaning in a self-contained way."

I think it disagrees with you, not with me.

>> They are all under the same category in <features.h>.
>> So this patch is completely incoherent, as was the previous one.
> 
> The main difference between those symbols and _FORTIFY_SOURCE is that
> the latter is completely optional

Enabling GNU extensions for ISO C source, forcing reentrancy on
non-threaded library code or enabling 64-bits file offset on
offset-bits-agnostic code is optional too.

> and the users might not care or do care enough to set it on their own.

If a packager wants to care more about the code than his/her upstream,
(s)he is free to force extra warnings on the code, and even to go berserk
with -Werror. But forcing this blindly and globally is just wrong. This is
Gentoo's bug, not VLC's.

> [1]
>
http://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html
> 
> Yet again stuff like _REENTRANT gets set by compiler flags and
> redefinition warnings are quite annoying and shutting them down by
> either adding -U or as the patch you dislike is probably the best for
> the poor soul trying to keep the warning count down.

Depending on the perspective, it either highlights a (deliberate) bug in
PulseAudio's pkg-config or the inconsistency of your proposed patches.

-- 
Rémi Denis-Courmont
Sent from my collocated server