[vlc-devel] [PATCH 2/4] Fixed extras/tools libtool check on MacOS X

[Rafaël Carré]

Hello,

Le 07/11/2013 13:22, Maxim Bublis a écrit :
> Pre-installed libtool on my MacOS X is not GNU and doesn't have --version
> option, only -V, so check in extra/tools/bootstrap always automatically
> fails which leads to building libtool.
> $ libtool -V
> Apple Inc. version cctools-846.2.4
> 
> However I have already installed GNU libtool from MacPorts. I guess
> MacPorts have same name conventions for GNU utilities as FreeBSD does,
> that's why GNU libtool is called glibtool on MacOS X.
> 
> $ glibtool --version
> libtool (GNU libtool) 2.4.2
> 
> glibtool and glibtoolize are correctly used by autoconf instead of Apple
> libtool.

Makes sense, I don't have a mac with me but I can look at this on this
week-end together with Felix.

P.S. please avoid top-posting

> On Thu, Nov 7, 2013 at 3:40 PM, Felix Paul Kühne <fkuehne at videolan.org>wrote:
> 
>> Hello Maxim,
>>
>> On 07.11.2013, at 11:47, Maxim Bublis <b at codemonkey.ru> wrote:
>>
>>> ---
>>> extras/tools/bootstrap | 12 +++++++++++-
>>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/extras/tools/bootstrap b/extras/tools/bootstrap
>>> index 578d8e6..34f3691 100755
>>> --- a/extras/tools/bootstrap
>>> +++ b/extras/tools/bootstrap
>>> @@ -54,10 +54,20 @@ else
>>> fi
>>> }
>>>
>>> +LIBTOOL=
>>> +case `uname` in
>>> +     Darwin)
>>> +             LIBTOOL=glibtool
>>> +     ;;
>>> +     *)
>>> +             LIBTOOL=libtool
>>> +     ;;
>>> +esac
>>
>> I'm not if I understand this patch's intention correctly. glibtool is not
>> provided by default on OS X. Why do you prefer it over libtool?
>> If you want to switch from libtool to glibtool, please provide reasons why
>> this would be a good idea and add the missing patch to compile it
>> automatically if not installed on a given Mac.
>>
>> Best regards,
>>
>> Felix