[vlc-devel] [PATCH 2/4] Fixed extras/tools libtool check on MacOS X

[Rafaël Carré]

Hi,

Le 07/11/2013 13:22, Maxim Bublis a écrit :
> Pre-installed libtool on my MacOS X is not GNU and doesn't have --version
> option, only -V, so check in extra/tools/bootstrap always automatically
> fails which leads to building libtool.

Looks normal so far.

> $ libtool -V
> Apple Inc. version cctools-846.2.4
> 
> However I have already installed GNU libtool from MacPorts. I guess
> MacPorts have same name conventions for GNU utilities as FreeBSD does,
> that's why GNU libtool is called glibtool on MacOS X.
> 
> $ glibtool --version
> libtool (GNU libtool) 2.4.2

The extras/tools folder is meant to replace the need for MacPorts/brew
so you should rather use one or the other.

We advise to move MacPorts/brew out of your path and use extras/tools
(at this point libtool --version will fail and GNU libtool will be built).

> glibtool and glibtoolize are correctly used by autoconf instead of Apple
> libtool.

The libtool binary we build on OSX ends up being 'libtool' even though
there's a also glibtool symlink.

Note that we don't apply any patch to libtool source.

So all in all I think this patch is not needed.