[vlc-devel] [PATCH] vlc 2.1.0 access_output/livehttp.c uninitialized data fix

LANGLOIS Olivier PIS -EXT olivier.pis.langlois at transport.alstom.com
Thu Oct 3 16:59:13 CEST 2013

> -----Original Message-----
> From: vlc-devel [mailto:vlc-devel-bounces at videolan.org] On Behalf Of Ilkka
> Ollakka
> Sent: Thursday, October 03, 2013 7:20 AM
> To: vlc-devel at videolan.org
> Subject: Re: [vlc-devel] [PATCH] vlc 2.1.0 access_output/livehttp.c
> uninitialized data fix
> On Tue, Oct 01, 2013 at 11:11:41PM +0000, LANGLOIS Olivier PIS -EXT wrote:
> > because not all sout_access_out_sys_t data members are initialized,
> f_seglen ended up being garbage and resulted to a very long duration for the
> first segment in the m3u8 index file:
> Hi,
> How big is that first segment in megabytes? I think this bug could more likely
> from from line 923 for not checking if p_buffer->i_dts is not VLC_TS_INVALID
> (if it is, we get funny opendts and length is huge even if file itself would be
> really small).
It is 0. My input is a live RTP/mpeg-ts multicast stream containing H.264 video. When I start vlc, it takes some time before it actually start to transfer the stream to HLS output. I have a bunch of traces like these at the beginning:

[0xb580c848] packetizer_h264 decoder warning: waiting for SPS/PPS

Here is the command line used for completeness:

cvlc rtp:// --verbose 1 --sout='#std{access=livehttp{seglen=10,delsegs=true,numsegs=5,index=/tmp/hls/mystream.m3u8,index-url=http://cwsla1gctd/hls/mystream-########.ts},mux=ts{use-key-frames},dst=/tmp/hls/mystream-########.ts}'

Maybe there is something else that could be improved but even so, I believe that having uninitialized variables laying around is still a bad idea. Don't you agree?

CONFIDENTIALITY : This e-mail and any attachments are confidential and may be privileged. If you are not a named recipient, please notify the sender immediately and do not disclose the contents to another person, use it for any purpose or store or copy the information in any medium.

More information about the vlc-devel mailing list