[vlc-devel] [PATCH] vlc 2.1.0 access_output/livehttp.c uninitialized data fix

[Ilkka Ollakka]

On Thu, Oct 03, 2013 at 02:59:13PM +0000, LANGLOIS Olivier PIS -EXT wrote:
> > Hi,

Hi,

> >
> > How big is that first segment in megabytes? I think this bug could more likely
> > from from line 923 for not checking if p_buffer->i_dts is not VLC_TS_INVALID
> > (if it is, we get funny opendts and length is huge even if file itself would be
> > really small).

> It is 0. My input is a live RTP/mpeg-ts multicast stream containing H.264 video. When I start vlc, it takes some time before it actually start to transfer the stream to HLS output. I have a bunch of traces like these at the beginning:
> 
> 
> Maybe there is something else that could be improved but even so, I believe that having uninitialized variables laying around is still a bad idea. Don't you agree?

Yes, if they are used before initialized. Could you try the patch
attached in this email if it fixes your 0-byte too-long-time first
segments too? I'm currently traveling so can't easily test it myself
(and I don't have similar access to such sample that you have).

-- 
Ilkka Ollakka 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vlc_hls_opendts.patch
Type: text/x-patch
Size: 645 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20131004/23666e65/attachment.bin>