[vlc-devel] [PATCH] contrib/flac: add support for clang 5.0

[Rafaël Carré]

Le 10/10/2013 14:09, Felix Paul Kühne a écrit :
> Hey Rafaël,
> 
> On 10.10.2013, at 13:44, Rafaël Carré <funman at videolan.org> wrote:
> 
>> Le 08/10/2013 19:38, Felix Paul Kühne a écrit :
>>> Hello,
>>>
>>> The attached patch removes a hack in flac, which leads to a conflict between GCC and clang versions.
>>
>> Can you explain the problem? It is not clear from the patch to see
>> what's going on with clang 5.0
> clang implements the GCC variables involved in this crazy configure.ac hack the flac people did so the checks don't work correctly and linking fails at a later stage.

Sorry but I still don't get it.

What are the values of GCC_*_VERSION for clang 5.0 ?
What is failing exactly?

http://gcc.gnu.org/wiki/Visibility says -fvisibility was added in gcc
4.0 and here you're removing the version check.

What happens with gcc 3.0 ? (I agree that it is old and unlikely to be
used on OSX but if we can send the patch upstream that would be great).

For fgnu89-inline I am not sure but if it's problematic as well I would
say those are 2 different problems no?

>> Also you need to use $(RECONF) if you patch configure.ac
> Valid point :-)
> 
> Cheers,
> 
> Felix