[vlc-devel] [PATCH] vlc 2.1.0 access_output/livehttp.c uninitialized data fix

Ilkka Ollakka ileoo at videolan.org
Mon Oct 14 19:17:47 CEST 2013

On Fri, Oct 04, 2013 at 08:18:01PM +0000, LANGLOIS Olivier PIS -EXT wrote:
> Ilkka,

> > > Maybe there is something else that could be improved but even so, I
> > believe that having uninitialized variables laying around is still a bad idea.
> > Don't you agree?

> > Yes, if they are used before initialized. Could you try the patch attached in
> > this email if it fixes your 0-byte too-long-time first segments too? I'm
> > currently traveling so can't easily test it myself (and I don't have similar access
> > to such sample that you have).

> I have tried your patch. First segment size is still 0 bytes:


Thanks for testing. I actually get same result with that calloc patchs
too, so it doesn't really fix underlying bug, just hides it more often.
I'll try to figure out why it generates that first segment to be 0 size.

Ilkka Ollakka
No character, however upright, is a match for constantly reiterated attacks,
however false.
		-- Alexander Hamilton
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20131014/c6a06576/attachment.sig>

More information about the vlc-devel mailing list