[vlc-devel] [PATCH] vlc 2.1.0 access_output/livehttp.c uninitialized data fix
LANGLOIS Olivier PIS -EXT
olivier.pis.langlois at transport.alstom.com
Fri Oct 4 22:18:01 CEST 2013
> > Maybe there is something else that could be improved but even so, I
> believe that having uninitialized variables laying around is still a bad idea.
> Don't you agree?
> Yes, if they are used before initialized. Could you try the patch attached in
> this email if it fixes your 0-byte too-long-time first segments too? I'm
> currently traveling so can't easily test it myself (and I don't have similar access
> to such sample that you have).
I have tried your patch. First segment size is still 0 bytes:
lano1106 at hpmini ~/vlc $ ls -l /tmp/hls
-rwxr-xr-x 0 lano1106 root 0 Oct 4 16:14 mystream-00000001.ts
-rwxr-xr-x 0 lano1106 root 374120 Oct 4 16:14 mystream-00000002.ts
-rwxr-xr-x 0 lano1106 root 358516 Oct 4 16:14 mystream-00000003.ts
-rwxr-xr-x 0 lano1106 root 366976 Oct 4 16:14 mystream-00000004.ts
-rwxr-xr-x 0 lano1106 root 605172 Oct 4 16:14 mystream-00000005.ts
-rwxr-xr-x 0 lano1106 root 400 Oct 4 16:15 mystream.m3u8
CONFIDENTIALITY : This e-mail and any attachments are confidential and may be privileged. If you are not a named recipient, please notify the sender immediately and do not disclose the contents to another person, use it for any purpose or store or copy the information in any medium.
More information about the vlc-devel