[vlc-devel] [PATCH] Fix for crashes in several modules when running VLC on osx 10.6

[Rafaël Carré]

Le 27/10/2013 18:51, David Fuhrmann a écrit :
> 
> Am 27.10.2013 um 18:33 schrieb Rémi Denis-Courmont
> <remi at remlab.net>:
> 
>> Le dimanche 27 octobre 2013 18:02:19 David Fuhrmann a écrit :
>>> Hi,
>>> 
>>> Since VLC 2.1, we noticed several crashes in different modules
>>> running on osx 10.6, if we compile the binary on osx 10.7 or
>>> later.
>> 
>> I don't know how the MacOS toolchain is designed.
>> 
>> But in general, the toolchain must be configured with the
>> *oldest* supported OS version to provide binary compatiblity. At
>> least, that is how it works on Windows (through _WIN32_WINNT) and
>> on all ELF-based platforms (through custom build roots).
> 
> Mac OS officially supports building on newer versions with newer
> osx SDKs, by giving a minimal version for osx which is supported at
> runtime.
> 
>> 
>>> As we have several features only working on 10.7 onwards, we
>>> need to compile the release binary on these newer versions. For
>>> 10.6, these features are deactivated.
>> 
>> Well, hmm, your "problems" very strongly suggest that you failed
>> to deactivate those "features". I think you answered your own
>> question.
> 
> These features are lion fullscreen and better window resizing,
> concerning the interface module. Additionally, there is an
> AVFoundation module only running on 10.7 onwards.
> 
> All of these features have absolutely _nothing_ to do with the
> crashes we are experiencing. (Especially, the interface runs fine
> on all platforms. Crashes are only happening in completely
> unrelated and osx unspecific modules.)

Can you share backtraces of these crashes?

Hard to suggest anything without knowing what's happening ;)

>>> Any comments or suggestions are appreciated. :-)
>> 
>> This adds about 80kiB of dead binary (stripped) code *per* plugin
>> on Windows or 1kiB on GNU/Linux. You do the maths with over 300
>> plugins.
> 
> I know its not the best solution. Thats why I ask for better ideas
> than this patch.
> 
> Cheers, David