[vlc-devel] [PATCH] Fix for crashes in several modules when running VLC on osx 10.6

[David Fuhrmann]

Am 28.10.2013 um 06:40 schrieb Rafaël Carré <funman at videolan.org>:

> Le 27/10/2013 18:51, David Fuhrmann a écrit :
>> 
>> Am 27.10.2013 um 18:33 schrieb Rémi Denis-Courmont
>> <remi at remlab.net>:
>> 
>>> Le dimanche 27 octobre 2013 18:02:19 David Fuhrmann a écrit :
>>>> Hi,
>>>> 
>>>> Since VLC 2.1, we noticed several crashes in different modules
>>>> running on osx 10.6, if we compile the binary on osx 10.7 or
>>>> later.
>>> 
>>> I don't know how the MacOS toolchain is designed.
>>> 
>>> But in general, the toolchain must be configured with the
>>> *oldest* supported OS version to provide binary compatiblity. At
>>> least, that is how it works on Windows (through _WIN32_WINNT) and
>>> on all ELF-based platforms (through custom build roots).
>> 
>> Mac OS officially supports building on newer versions with newer
>> osx SDKs, by giving a minimal version for osx which is supported at
>> runtime.
>> 
>>> 
>>>> As we have several features only working on 10.7 onwards, we
>>>> need to compile the release binary on these newer versions. For
>>>> 10.6, these features are deactivated.
>>> 
>>> Well, hmm, your "problems" very strongly suggest that you failed
>>> to deactivate those "features". I think you answered your own
>>> question.
>> 
>> These features are lion fullscreen and better window resizing,
>> concerning the interface module. Additionally, there is an
>> AVFoundation module only running on 10.7 onwards.
>> 
>> All of these features have absolutely _nothing_ to do with the
>> crashes we are experiencing. (Especially, the interface runs fine
>> on all platforms. Crashes are only happening in completely
>> unrelated and osx unspecific modules.)
> 
> Can you share backtraces of these crashes?

The backtraces are not really helpful. For example, from various tickets see:
https://trac.videolan.org/vlc/attachment/ticket/9140/crash-seeking-subs.txt
https://trac.videolan.org/vlc/attachment/ticket/9527/vlc-crash-log.txt
https://trac.videolan.org/vlc/attachment/ticket/9140/crash-libmp4.txt

It somehow looks like the integration of only the used functions from compat either does not work at all on osx, or it somehow interfers with the functions implemented in the standard libraries. For me it looks like they are not copied into the modules, and on osx 10.7 or later the system implementation is used.

j-b wrote that the concering functions are probably getdelim, strndup and strnlen.

Best,
David


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20131028/0fdca702/attachment.sig>