[vlc-devel] [PATCH] nVidia affinity

[Jean-Baptiste Kempf]

On 29 Aug, David R Robison wrote :
> +libglwin32_plugin_la_LIBADD = $(AM_LIBADD) -lglew32 -lopengl32 -lgdi32 
> -lole32 -luuid

??

> +#define GLEW_NO_GLU

I don't see the use of this one.
Where are you actually using libglew? All the functions you are using
seem to be part of the normal mingw-w64 install, tbh.

> +#define HW_GPU_AFFINITY_TEXT N_("GPU affinity")
> +#define HW_GPU_AFFINITY_LONGTEXT N_(\
> +    "select GPU affinity.")

Too similar, remove one and use it twice.

> +    /* process selected GPU affinities */
> +    int nVidiaAffinity = var_GetInteger(vd, "gpu-affinity");

This should be Inherit, no?


More or less, this patch seems now in almost great shape, thanks :)

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device