[vlc-devel] [PATCH] nVidia affinity

[David R Robison]

Thanks for the input, I'll make the changes. One question,

I am confused when to use var_GetInteger and when to use 
var_InheritInteger.

I am embedding vlc into my application using the libvlc sdk. I have a 
set of command line parameters that I send to the Media Player Factory 
and then another set I send to the Play Media function of the Media 
Player. When I used InheritInteger I was not seeing the parameter I 
passed to Play Media but I do see it when I use GetInteger. Maybe I 
missed something when trying the Inherit. Can you clarify the usage?

David

David R Robison
Open Roads Consulting, Inc.
103 Watson Road, Chesapeake, VA 23320
phone: (757) 546-3401
e-mail: drrobison at openroadsconsulting.com
web: http://openroadsconsulting.com
blog: http://therobe.blogspot.com
book: http://www.xulonpress.com/bookstore/bookdetail.php?PB_ISBN=9781597816526

On 9/2/2013 2:17 PM, Jean-Baptiste Kempf wrote:
> On 29 Aug, David R Robison wrote :
>> +libglwin32_plugin_la_LIBADD = $(AM_LIBADD) -lglew32 -lopengl32 -lgdi32
>> -lole32 -luuid
> ??
>
>> +#define GLEW_NO_GLU
> I don't see the use of this one.
> Where are you actually using libglew? All the functions you are using
> seem to be part of the normal mingw-w64 install, tbh.
>
>> +#define HW_GPU_AFFINITY_TEXT N_("GPU affinity")
>> +#define HW_GPU_AFFINITY_LONGTEXT N_(\
>> +    "select GPU affinity.")
> Too similar, remove one and use it twice.
>
>> +    /* process selected GPU affinities */
>> +    int nVidiaAffinity = var_GetInteger(vd, "gpu-affinity");
> This should be Inherit, no?
>
>
> More or less, this patch seems now in almost great shape, thanks :)
>
> Best regards,
>



This email communication (including any attachments) may contain confidential and/or privileged material intended solely for the individual or entity to which it is addressed.
If you are not the intended recipient, please delete this email immediately.