[vlc-devel] [PATCH 2/2] avcodec: add opus fourcc

[Rafaël Carré]

Le 19/09/2013 08:56, Tristan Matthews a écrit :
> ---
>  modules/codec/avcodec/fourcc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/modules/codec/avcodec/fourcc.c b/modules/codec/avcodec/fourcc.c
> index 3746ac8..9a5c3b5 100644
> --- a/modules/codec/avcodec/fourcc.c
> +++ b/modules/codec/avcodec/fourcc.c
> @@ -311,6 +311,10 @@ static const struct
>  
>      { VLC_CODEC_DVAUDIO, AV_CODEC_ID_DVAUDIO, AUDIO_ES },
>  
> +#if LIBAVCODEC_VERSION_CHECK( 54, 29, 0, 60, 100 )
> +    { VLC_CODEC_OPUS, AV_CODEC_ID_OPUS, AUDIO_ES },
> +#endif
> +
>      { VLC_CODEC_MACE3, AV_CODEC_ID_MACE3, AUDIO_ES },
>      { VLC_CODEC_MACE6, AV_CODEC_ID_MACE6, AUDIO_ES },

I can neither decode neither encode with avcodec :

Encode: (acodec=Opus,aenc=avcodec)
[libopus @ 0x7fbb8c02c780] Error getting output packet
[0x7fbb8c028878] avcodec encoder error: Encoding problem..

Decode: (--codec=avcodec)
[0x7fa79c017e88] main decoder debug: looking for decoder module matching
"avcodec": 40 candidates
[libopus @ 0x7fa79c01d0a0] Inconsistent channel mapping.
[libopus @ 0x7fa79c01d0a0] Unable to create decoder: invalid argument
[0x7fa79c017e88] avcodec decoder error: cannot open codec (Opus Audio)
[0x7fa79c017e88] main decoder debug: using decoder module "opus"
[0x7fa79c017e88] opus decoder debug: Opus audio with 2 channels

Demux: (--demux=avformat)
[0x7f3818005698] avformat demux debug: detected format: ogg
[ogg @ 0x7f381c010d40] Codec not found
[ogg @ 0x7f381800dc20] Codec not found

Mux: (mux=avformat{mux=ogg})
As you said it doesn't generate a correct OpusHead header.


So I guess this patch makes no sense for now, until we fix these issues