[vlc-devel] [PATCH] access: dvb: Realloc block to actually used size.
julian at jusst.de
Fri Sep 20 14:42:08 CEST 2013
Am 20.09.2013 14:23, schrieb Francois Cartegnie:
> Le 20/09/2013 14:16, Denis Charmet a écrit :
>> I'd rather see a basic use of smaller buffer or an adaptation
>> of the BUFSIZE using previous val values.
> Or just make use of block_Chain with smaller buffers as it will merge
> data on read ?
I just had a look at block_Chain. As this seems to be a linked list of
blocks it wouldn't solve the issue in first place. One might reduce the
buffer size in first place and then chain the smaller buffers, but I
don't see much advantage over just using smaller buffers then.
Still thinkin about smaller buffers it will have an impact on
performance as well, when bigger buffers could be used. Dynamic sizes
might be worth a try. If a majority would reject the realloc solution,
which in fact is used in several access modules as of now, I might give
a try on dynamic adaptation.
Regarding the mem vs perf discussion: I understand that you won't care
about 200MB wasted RAM on a 16GB RAM machine, but seeing VLC being used
on embedded and mobile devices 200MB wasted RAM are a major issue.
More information about the vlc-devel