[vlc-devel] [PATCH] access: dvb: Realloc block to actually used size.

[Denis Charmet]

Le vendredi 20 septembre 2013 à 02:42:08, Julian Scheel a écrit :
> I just had a look at block_Chain. As this seems to be a linked list
> of blocks it wouldn't solve the issue in first place. One might
> reduce the buffer size in first place and then chain the smaller
> buffers, but I don't see much advantage over just using smaller
> buffers then.
Less unused memory by packet, udp usually use the MTU so it could easily
be reduced to 7 TS packets.

> If a majority would reject the realloc
> solution, which in fact is used in several access modules as of now,
> I might give a try on dynamic adaptation.
>
For the record, I wasn't rejecting the realloc, just stating that it's a
debatable stance. Everyone has an opinion on it, I'm also interested in
other point of view about that.
 
> Regarding the mem vs perf discussion: I understand that you won't
> care about 200MB wasted RAM on a 16GB RAM machine, but seeing VLC
> being used on embedded and mobile devices 200MB wasted RAM are a
> major issue.

I'm afraid of your streams if you can lose 200 MB of data in buffering
(especially with low bandwidth ones) and I can't really picture the dtv 
access as an major access used on embedded application. But fair enough,
just beware of the memory fragmentation.

Regards,

-- 
Denis Charmet - TypX
Le mauvais esprit est un art de vivre