[vlc-devel] [PATCH] directsound: use software gain only when amplifying

Pierre Ynard linkfanel at yahoo.fr
Sat Sep 21 03:16:33 CEST 2013

> > +    /* millibels from linear amplification */
> > +    LONG mb = lroundf( 2000.f * log10f( __MIN( volume, 1.f ) ));
> To maintain volume consistency between versions you should keep the
> 6000. 

I'm confused. This patch is aimed at the 2.1 release and would revert
the change from 2000 of last month. Anyway if you remove the default
gain don't you need to change this factor too to keep things consistent?

> I already proposed tis solution but introduce a delay when you are over
> 100% and when you are going under.

And I reckon that was a good idea on your part! Yes there's a delay over
100% and yes that makes volume latency inconsistent depending on whether
you're under or over 100%, but at this point that's the best compromise
I have to offer.

Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."

More information about the vlc-devel mailing list