[vlc-devel] [PATCH] directsound: use software gain only when amplifying

[Denis Charmet]

Le samedi 21 septembre 2013 à 03:16:33, Pierre Ynard a écrit :
> > > +    LONG mb = lroundf( 2000.f * log10f( __MIN( volume, 1.f ) ));
> > 
> > To maintain volume consistency between versions you should keep the
> > 6000. 
> 
> I'm confused. This patch is aimed at the 2.1 release and would revert
> the change from 2000 of last month. Anyway if you remove the default
> gain don't you need to change this factor too to keep things consistent?
> 
Because the volume was cubed before being used in the log10. So you
either use 2000 * log10( volume * volume * volume ); or 6000 * log10(
volume );

Regards,

-- 
Denis Charmet - TypX
Le mauvais esprit est un art de vivre