[vlc-devel] [PATCH] missing MODULE_NAME_IS_ for android

Rémi Denis-Courmont remi at remlab.net
Sat Sep 21 17:40:56 CEST 2013


Le samedi 21 septembre 2013 17:29:08 XilasZ a écrit :
> > > And anyway, MODULE_NAME_IS_* does _not_ participate in vlc_entry_*
> 
> I don't know exactly why,

Sorry but you should understand your own patches before you post them. 
Shooting in the dark is fine in your corner on your machine, but not in the 
main tree. It's only the first step.

> but at least on android port it does.

If you are not convinced you can add at the top of your .c files and leave it 
out of the Makefile and see for yourself that it solves absolutely nothing:

#define MODULE_NAME_IS_foo

And that will not solve your problem, unless maybe you rely on something out 
of the official tree (in that case, your patch is incomplete).

-- 
Rémi Denis-Courmont
http://www.remlab.net/




More information about the vlc-devel mailing list