[vlc-devel] [PATCH] missing MODULE_NAME_IS_ for android

[Jean-Baptiste Kempf]

On 21 Sep, Rémi Denis-Courmont wrote :
> Le samedi 21 septembre 2013 17:29:08 XilasZ a écrit :
> > > > And anyway, MODULE_NAME_IS_* does _not_ participate in vlc_entry_*
> > 
> > I don't know exactly why,
> 
> Sorry but you should understand your own patches before you post them. 
> Shooting in the dark is fine in your corner on your machine, but not in the 
> main tree. It's only the first step.

Well, autotools patches are difficult, and you can't blame Sebastien to
propose patches here, on that.

> > but at least on android port it does.
> 
> If you are not convinced you can add at the top of your .c files and leave it 
> out of the Makefile and see for yourself that it solves absolutely nothing:
> 
> #define MODULE_NAME_IS_foo

Well, it does fix the android static compilation of libvlc.so.
It mihgt be a collateral damage :)

> And that will not solve your problem, unless maybe you rely on something out 
> of the official tree (in that case, your patch is incomplete).

The patch is probably incomplete, but so far, it seem to work.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device