[vlc-devel] [PATCH] missing MODULE_NAME_IS_ for android

Rémi Denis-Courmont remi at remlab.net
Sat Sep 21 18:20:40 CEST 2013


Le samedi 21 septembre 2013 17:16:12 XilasZ a écrit :
> if you have a better solution, please share it.

We have been through this before several times. The reviewer's responsibility 
is to determine whether a patch is right or wrong, and that is all. We are 
short on developers but we are even shorter on reviewers. You cannot just dump 
quick hacks and expect the reviewers to clean up afterwards, neither that 
negative reviews will always come with a constructive solution.

Furthermore, you should provide context in your patches. In particular, you 
should state what the problem actually is, and how the patch solves it, than 
merely paraphrase the diff.

Sorry but "missing MODULE_NAME_IS_ for android" is very uninformative for 
anyone who is not involved in the Android port.

Rémi Denis-Courmont

More information about the vlc-devel mailing list