[vlc-devel] [PATCH] missing MODULE_NAME_IS_ for android

[Rémi Denis-Courmont]

Le samedi 21 septembre 2013 18:09:56 Jean-Baptiste Kempf a écrit :
> On 21 Sep, XilasZ wrote :
> > > > Sure, but that is obviously not the right fix. MODULE_NAME_IS_ is a
> > > > hack, and it's not the first time this is brought up.
> > 
> > i didn't know that, what is it exactly ?
> 
> IIRC, it was discussed 3 or 4 years ago at FOSDEM, about why it was bad
> practice to rely on MODULE_NAME and vlc_find_by_name, notably because of
> the module compiled out-of-tree.
> 
> Noone had a correct fix in mind, and that is why we still use those.

Only MODULE_STRING was ever required -by msg_* macros- and that should already 
be fixed nowadays. MODULE_NAME_IS_ was only ever used by a few specific in-tree 
plugins.

And MODULE_NAME is just dead wood from the forgotten time of VLC_ADD_BUILTINS.

-- 
Rémi Denis-Courmont
http://www.remlab.net/