[vlc-devel] [PATCH] missing MODULE_NAME_IS_ for android

[Rémi Denis-Courmont]

Le samedi 21 septembre 2013 18:05:50 Jean-Baptiste Kempf a écrit :
> On 21 Sep, Rémi Denis-Courmont wrote :
> > Le samedi 21 septembre 2013 17:29:08 XilasZ a écrit :
> > > > > And anyway, MODULE_NAME_IS_* does _not_ participate in vlc_entry_*
> > > 
> > > I don't know exactly why,
> > 
> > Sorry but you should understand your own patches before you post them.
> > Shooting in the dark is fine in your corner on your machine, but not in
> > the
> > main tree. It's only the first step.
> 
> Well, autotools patches are difficult, and you can't blame Sebastien to
> propose patches here, on that.

People seem to think I understand autotools because of superior intelligence, 
and thus normal people cannot be expect to understand them.

No. I roughly understand them because I read the autoconf, automake and 
libtool documentation. And you don't need to be a lawyer to grok it.

> > > but at least on android port it does.
> > 
> > If you are not convinced you can add at the top of your .c files and leave
> > it out of the Makefile and see for yourself that it solves absolutely
> > nothing:
> > 
> > #define MODULE_NAME_IS_foo
> 
> Well, it does fix the android static compilation of libvlc.so.

I don't know what weird stuff there may be in the Android specific build parts, 
but whatever hacks that may need belongs in the Android tree.

In vlc.git, MODULE_NAME_IS_ has absolutely _zero_ effects on the build, even if 
static. It is *only* used to compile different parts of the same .c file 
differently in multiple plugins (hence MSW, Vorbis, x264 and chromas).

-- 
Rémi Denis-Courmont
http://www.remlab.net/