[vlc-devel] [PATCH] missing MODULE_NAME_IS_ for android

Jean-Baptiste Kempf jb at videolan.org
Sat Sep 21 18:53:22 CEST 2013

On 21 Sep, Rémi Denis-Courmont wrote :
> We have been through this before several times. The reviewer's responsibility 
> is to determine whether a patch is right or wrong, and that is all.

We agreed on that. But sometimes, an hint of a better solution is
welcome, but agreed, only if one knows.

> We are 
> short on developers but we are even shorter on reviewers.

That is sure. And since VDD, we've had more people reviewing than
before, you cannot deny this. THis big fight is because we've had more

> You cannot just dump 
> quick hacks and expect the reviewers to clean up afterwards, neither that 
> negative reviews will always come with a constructive solution.

Sebastien sent a patch that was actually wrkgin for his problem, you
can't blame him for that.

For the reviews, noone said it should be always with a solution.

> Furthermore, you should provide context in your patches. In particular, you 
> should state what the problem actually is, and how the patch solves it, than 
> merely paraphrase the diff.
> Sorry but "missing MODULE_NAME_IS_ for android" is very uninformative for 
> anyone who is not involved in the Android port.

And Felix and I have been guilty of the same, and people complained,
notably Rafael.

Yet, this has nothing to do with Android, but with static linking,
impacting also iOS.

Best regards,

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list