[vlc-devel] [PATCH] Adding caf file demuxer module.

[Jean-Baptiste Kempf]

On 25 Sep, Matthias Keiser wrote :
> +    if( i_fmt == VLC_CODEC_DVD_LPCM )
> +    {
> +        if( !i_frames_per_packet || !i_channels_per_frame )
> +        {
> +            msg_Err( p_demux, "invalid codec" );

I think this message is wrong.

> +        msg_Err( p_demux, "Unknown alac magic cookie. Passing it on to the decoder as is and hoping for the best." );

msg_Warn

> +    if( !p_sys->fmt.p_extra )
> +    {
> +        return VLC_ENOMEM;
> +    }

You don't need the brackets in those case, but this is not something you
must fix.

> +    uint8_t *p_extra = ( uint8_t * )p_sys->fmt.p_extra; /* Avoid pointer arithmetic warnings. */

I don't see the need for the comment.

The rest, LGTM.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device