[vlc-devel] [PATCH] Adding caf file demuxer module.

[Jean-Baptiste Kempf]

Ah, sorry.

On 25 Sep, Matthias Keiser wrote :
> +    p_demux->pf_control = Control;
> +    p_demux->pf_demux = Demux;

You should assign those later, to be honest.

> +            case VLC_FOURCC( 'd', 'e', 's', 'c' ):
> +
> +                if( i_idx != 0 )
> +                {
> +                    msg_Err( p_demux, "The audio description chunk must be the first chunk in a caf file." );
> +                    i_error = VLC_EGENERIC;
> +                    goto caf_open_end;
> +                }
> +
> +                i_error = ReadDescChunk( p_demux );
> +                break;
> +
> +            case VLC_FOURCC( 'd', 'a', 't', 'a' ):
> +
> +                i_error = ReadDataChunk( p_demux, i_size );
> +                break;
> +
> +            case VLC_FOURCC( 'p', 'a', 'k', 't' ):
> +
> +                i_error = ReadPaktChunk( p_demux );
> +                break;
> +
> +            case VLC_FOURCC( 'k', 'u', 'k', 'i' ):
> +
> +                i_error = ReadKukiChunk( p_demux, i_size );
> +                break;
> +
> +            default:
> +
> +                b_handled = false;
> +                break;
> +        }
> +
> +        if( i_error )
> +            goto caf_open_end;

If you fail here, did we advance in the stream? I think so, right?

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device