[vlc-devel] [PATCH] Adding caf file demuxer module.

[TristanInc]

Sorry I need some clarifications.

>> +    p_demux->pf_control = Control;
>> +    p_demux->pf_demux = Demux;
> 
> You should assign those later, to be honest.

What exactly do you mean. Assign after we're sure we don't return an error? I checked other demux modules, they seem to do it similarly to how I did it.

>> +        if( i_error )
>> +            goto caf_open_end;
> 
> If you fail here, did we advance in the stream? I think so, right?

Yes. Should I stream_Seek(s, 0) at the end of Open (at least if we have an error)?

>> +    if( i_fmt == VLC_CODEC_DVD_LPCM )
>> +    {
>> +        if( !i_frames_per_packet || !i_channels_per_frame )
>> +        {
>> +            msg_Err( p_demux, "invalid codec" );
> 
> I think this message is wrong.

But LPCM with 0 bytes per frame is kinda invalid, isn't it? What would you prefer? "Invalid codec parameters" or some such?

Thanks for your patience.

Matthias