[vlc-devel] [PATCH] vpx: force bash for build scripts

[Rafaël Carré]

Hi,

On 04/02/14 23:26, Sean McGovern wrote:
> ---
>  contrib/src/vpx/rules.mak |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/contrib/src/vpx/rules.mak b/contrib/src/vpx/rules.mak
> index a22abd1..adae3c1 100644
> --- a/contrib/src/vpx/rules.mak
> +++ b/contrib/src/vpx/rules.mak
> @@ -20,6 +20,7 @@ ifneq ($(which bash),/bin/bash)
>  		s,^\#!/bin/bash,\#!`which bash`,g \
>  		`grep -Rl ^\#!/bin/bash libvpx-$(VPX_VERSION)`
>  endif
> +	sed -i.orig -e s,^\#!/bin/sh,\#!`which bash`, libvpx-$(VPX_VERSION)/{configure,build/make/*.sh}
>  	$(MOVE)

Is there any bash syntax here?

The scripts seem to work fine on Debian where /bin/sh is dash and
shouldn't support bash syntax.
(Although there might be a bug in dash though).

I'd like more details so eventually we can send patches to Google.

Does libvpx.git work better than 1.3.0 ?

>  DEPS_vpx =
>