[vlc-devel] [PATCH 2/3] video_output/mmal: Add mmal based video output plugin

[Julian Scheel]

On 05.04.2014 22:04, Rémi Denis-Courmont wrote:
> Le samedi 5 avril 2014, 20:15:49 Julian Scheel a écrit :
>>>> +    vc_tv_unregister_callback(tvservice_cb);
>>>
>>> Is that reference counted per callback? If not, it will crash on multiple
>>> video tracks.
>>
>> vc_tv callbacks are tracked as a list in the vcos implementation so
>> multiple callbacks can be registered and unregistered independently. So
>> I don't see a problem here.
>
> You have:
>
> +    vc_tv_register_callback(tvservice_cb, vd);
>
> but:
>
> +    vc_tv_unregister_callback(tvservice_cb);
>
> How do you know which 'vd' to remove from the list if there are more than one?

Ok, solving this with an update to rpi-userland, which is merged already:

https://github.com/raspberrypi/userland/pull/162

So we will change to vc_tv_unregister_callback_full(tvservice_cb, vd) here.