[vlc-devel] [RFC] Equalizer cannot be disabled once equalizer-bands are set

[Rémi Denis-Courmont]

Le vendredi 11 avril 2014, 12:19:11 David Fuhrmann a écrit :
> While debugging the current equalizer problems on the mac (#9350), I found
> out that the equalizer never gets disabled once "equalizer-bands“ is set to
> some value.

I believe that was intended, that the equalizer gets automatically enabled 
when bands are specified.

> In the GUI equalizer panel, we use playlist_EnableAudioFilter to disable the
> equalizer filter. This, in turn, will call aout_ChangeFilterString and
> afterwards the filter chain is restarted.
> 
> During restart, aout_FiltersNew is called which registers an equalizer
> callback for „equalizer“ and "equalizer-bands“. Afterwards, this callback
> is triggered directly (in src/audio_output/filters.c:424). The callback, in
> turn, directly re-adds the equalizer to the filter chain which seems wrong.

It seems right to me, or at least consistent.

-- 
Rémi Denis-Courmont
http://www.remlab.net/