[vlc-devel] [PATCH 02/10] MED Support - Core controls and definitons

[Roiy Shpaner]

Hey Rémi,

Thanks for the review, 

Regarding cluttering, the only line added in vlc_common.h is the following, which is based on the existing seekpoint struct

typedef struct seekpoint_t seekpoint_t;
+typedef struct seeksegment_t seeksegment_t;
 typedef struct info_t info_t;

So it follows the existing style, and it's the only way I see of defining it, am I missing something?

Regarding leaks, I don't recall anyone pointing that out, Francois was the only other person that gave feedback, and it wasn't about leaks, could you please point to the place of interest?

Thanks again!
Roiy


> -----Original Message-----
> From: vlc-devel [mailto:vlc-devel-bounces at videolan.org] On Behalf Of Rémi
> Denis-Courmont
> Sent: April-16-14 2:33 AM
> To: Mailing list for VLC media player developers
> Subject: Re: [vlc-devel] [PATCH 02/10] MED Support - Core controls and
> definitons
> 
> This still clutters vlc_common.h for n ogood reasons and still leaks (I don't
> remember who pointed that out, Denis maybe).
> 
> --
> Rémi Denis-Courmont
> Sent from my collocated server
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel