[vlc-devel] [PATCH 02/10] MED Support - Core controls and definitons

[Rémi Denis-Courmont]

Le mercredi 16 avril 2014, 11:30:20 Roiy Shpaner a écrit :
> Hey Rémi,
> 
> Thanks for the review,
> 
> Regarding cluttering, the only line added in vlc_common.h is the following,
> which is based on the existing seekpoint struct

This is there only for the historical <vlc_symbol.h> reason. Don't do this in 
new code.

> Regarding leaks, I don't recall anyone pointing that out, Francois was the
> only other person that gave feedback, and it wasn't about leaks, could you
> please point to the place of interest?

At least usage of realloc() is leaking.

-- 
Rémi Denis-Courmont
http://www.remlab.net/