[vlc-devel] [patch] Mac/iOS VLCKit fixes to VLCMediaPlayer dealloc method

[Felix Paul Kühne]

Hey Florent,

On 17.04.2014, at 11:43, Florent Pillet <fpillet at gmail.com> wrote:

> Two fixes here:
> 
> - if the stream hasn't been stopped by the time dealloc is called, stopping it is useless because dealloc will most likely occur on the main thread, and the [stop] method executes asynchronously on a background thread. This is a hopeless situation. A dispatch_sync() could be used but since it could cause a deadlock, it's better to have the developer properly stop the stream before disposing of the player.
> 
> - if a stream has completely failed to start (i.e. forbidden RTSP access), the player's state is libvlc_NothingSpecial. Handle this case in the debug assert.

Thanks! Merged!

Best regards,

Felix