[vlc-devel] [PATCH 1/1] Supporting ONVIF PRofile-G recording playback

[Rémi Denis-Courmont]

Hello,

Le lundi 4 août 2014, 14:17:26 David R. Robison a écrit :
> > That's a lot of code for just one variable.
> 
> This is because it has two values like the COORS, a from and a to value.

Yes, and? How does that justify the need for a variable and a single one?

> >>    /**@}*/
> >>    
> >>    /** \defgroup var_flags Additive flags
> >> 
> >> diff --git a/lib/libvlc.sym b/lib/libvlc.sym
> >> index c0c66dd..858af30 100644
> >> --- a/lib/libvlc.sym
> >> +++ b/lib/libvlc.sym
> >> @@ -173,6 +173,7 @@ libvlc_media_player_set_nsobject
> >> 
> >>    libvlc_media_player_set_position
> >>    libvlc_media_player_set_rate
> >>    libvlc_media_player_set_time
> >> 
> >> +libvlc_media_player_set_timerng
> > 
> > Maybe just me, but that does not sound very evocative as a function name.
> > 
> > Plus RNG means Random Number Generator in IT context.
> 
> OK, I could call it set_absolute_range. How does this sound?

absolute range of what? set_time_range

> > How is that different from setting (start-)time *and* end-time?
> 
> Hmmm. Maybe I missed something. I see a set time but not a set end time.
> Also, by allowing both to be set at once we can process them together
> which means a single PLAY request to the video source. I guess I could
> set the end first and then the start to get the same effect.

start-time and end-time (and run-time), not "time".

> > Not reentrant.
> 
> Is it the call to strftime that is not reentrant?

This has nothing specific to VLC. Refer to the specs.

-- 
Rémi Denis-Courmont
http://www.remlab.net/