[vlc-devel] [PATCH 1/1] Supporting ONVIF PRofile-G recording playback

[David R. Robison]

Also inline...

David R Robison
Open Roads Consulting, Inc.
103 Watson Road, Chesapeake, VA 23320
phone: (757) 546-3401
e-mail: david.robison at openroadsconsulting.com
web: http://openroadsconsulting.com
blog: http://therobe.blogspot.com
book: http://www.xulonpress.com/bookstore/bookdetail.php?PB_ISBN=9781597816526

On 8/4/2014 2:29 PM, Rémi Denis-Courmont wrote:
> Hello,
>
> Le lundi 4 août 2014, 14:17:26 David R. Robison a écrit :
>>> That's a lot of code for just one variable.
>> This is because it has two values like the COORS, a from and a to value.
> Yes, and? How does that justify the need for a variable and a single one?
My thoughts was to use a single variable which I now call "timerng" (but 
I will change that) so that when I set the time range I get a single 
callback for the one variable. However, I can get around this if I 
create a time variable for "start-time" and one for "end-time". If I set 
the end-time first then I can detect that the start-time has not been 
set and not cause an extra PLAY request.

I do think, however, that I need two new variables so I can determine if 
I am requesting recorded video or live video from the RTSP source. The 
difference is whether I send the "Range: npt" or the "Range: clock" header.
I could create two variables for recorded_playback_start and 
recorded_playback_stop. Thoughts?
>
>>>>     /**@}*/
>>>>     
>>>>     /** \defgroup var_flags Additive flags
>>>>
>>>> diff --git a/lib/libvlc.sym b/lib/libvlc.sym
>>>> index c0c66dd..858af30 100644
>>>> --- a/lib/libvlc.sym
>>>> +++ b/lib/libvlc.sym
>>>> @@ -173,6 +173,7 @@ libvlc_media_player_set_nsobject
>>>>
>>>>     libvlc_media_player_set_position
>>>>     libvlc_media_player_set_rate
>>>>     libvlc_media_player_set_time
>>>>
>>>> +libvlc_media_player_set_timerng
>>> Maybe just me, but that does not sound very evocative as a function name.
>>>
>>> Plus RNG means Random Number Generator in IT context.
>> OK, I could call it set_absolute_range. How does this sound?
> absolute range of what? set_time_range
That makes since. maybe, however, since this change deals with recorded 
video only, maybe I could call it set_recorded_playback_range. Thoughts?
>
>>> How is that different from setting (start-)time *and* end-time?
>> Hmmm. Maybe I missed something. I see a set time but not a set end time.
>> Also, by allowing both to be set at once we can process them together
>> which means a single PLAY request to the video source. I guess I could
>> set the end first and then the start to get the same effect.
> start-time and end-time (and run-time), not "time".
>
>>> Not reentrant.
>> Is it the call to strftime that is not reentrant?
> This has nothing specific to VLC. Refer to the specs.
>



This email communication (including any attachments) may contain confidential and/or privileged material intended solely for the individual or entity to which it is addressed.
If you are not the intended recipient, please delete this email immediately.