[vlc-devel] [vlc-commits] demux: ts: include time.h

[Francois Cartegnie]

Le 17/08/2014 03:15, Rémi Denis-Courmont a écrit :

> However, I find the lack of considerations for DST very suspicious. Looking at 
> the code, I assume the EIT time values are expressed in local time.
> 

"start_time: This 40-bit field contains the start time of the event in
Japan Standard Time (JST) and Modified Julian Date (MJD)"

That's definitively only for Japan, like other descriptors timestamps.
It also points out that BCD time conversion is done over MJD data, which
is currently wrong :/

> If on the one hand the code is only meant for within Japan, then I think a 
> fixed offset of minus nine hours may actually be better: the values will be 
> computed correctly even if the computer is not in JST.
> 
> If on the other hand the code targets in all ISDB countries, then DST handling 
> should be required for Chile, Paraguay, and some of Brazil's states.

Have to fully understand the Brazilian spec which is already different
for text encoding, ...

Francois