[vlc-devel] [PATCH 2/2] avcodec: use i_aligned_width and i_aligned_height

Thomas Guillem thomas at gllm.fr
Fri Dec 12 10:17:26 CET 2014



On Fri, Dec 12, 2014, at 09:44, Thomas Guillem wrote:
> 
> On Thu, Dec 11, 2014, at 22:25, Rémi Denis-Courmont wrote:
> > Le jeudi 11 décembre 2014, 21:16:53 Jean-Baptiste Kempf a écrit :
> > > With those 2 patches, and testing on most of our supported platforms,
> > > (including the ones I don't like) using numerous samples and formats, for
> > > 2 days, we have seen no major regressions.
> > 
> > AFAICT this (second) patch is only a very round-about and obscured revert
> > of 
> > 6f98d4ba. Concretely, it removes the perhaps most common source of green
> > lines 
> > and breaks direct rendering.
> > 
> > Unless I missed something obvious, after the pair of patches,
> > i_aligned_width 
> > and i_aligned_height are write-only parameters.
> 
> These parameters are used in src/misc/picture.c when allocating a new
> picture.

Ok, due to a recent cleanup of my commits, it's not used anymore, I'm on
it.

> I checked I have the "enabling direct rendering" log, but I also got
> when I don't set i_aligned_*. Do you have a sample/usecase where you
> need absolutely aligned pictures using avcodec dr?
> 
> > 
> > -- 
> > Rémi Denis-Courmont
> > http://www.remlab.net/
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list