[vlc-devel] [PATCH 2/2] avcodec: use i_aligned_width and i_aligned_height

Rémi Denis-Courmont remi at remlab.net
Fri Dec 12 11:35:52 CET 2014


Le 2014-12-12 11:44, Thomas Guillem a écrit :
> On Thu, Dec 11, 2014, at 22:25, Rémi Denis-Courmont wrote:
>> Le jeudi 11 décembre 2014, 21:16:53 Jean-Baptiste Kempf a écrit :
>> > With those 2 patches, and testing on most of our supported 
>> platforms,
>> > (including the ones I don't like) using numerous samples and 
>> formats, for
>> > 2 days, we have seen no major regressions.
>>
>> AFAICT this (second) patch is only a very round-about and obscured 
>> revert
>> of
>> 6f98d4ba. Concretely, it removes the perhaps most common source of 
>> green
>> lines
>> and breaks direct rendering.
>>
>> Unless I missed something obvious, after the pair of patches,
>> i_aligned_width
>> and i_aligned_height are write-only parameters.
>
> These parameters are used in src/misc/picture.c when allocating a new
> picture.

If that were the case, any code path (rightfully) assuming that the 
scanline pitch and the video format width match would break.
Regardless, DR is _not_ typically performed with the default/core 
picture allocator.

-- 
Rémi Denis-Courmont



More information about the vlc-devel mailing list