[vlc-devel] [vlc-commits] Contribs: fix zvbi compilation for Android

Jean-Baptiste Kempf jb at videolan.org
Sun Dec 14 17:13:02 CET 2014

On 14 Dec, Felix Paul Kühne wrote :
> Why are you removing the HAVE_WIN32 here? This adds a build system dependency of gettext, which is not desirable when compiling for iOS.

Because Win32 and Android patches need RECONF now.
And this avoids numerous ifdefs that are not necessary.

> Is RECONF actually needed? To succeed in compiling for iOS and OS X, UPDATE_AUTOCONFIG is absolutely sufficient.. Maybe add a ifndef HAVE_DARWIN_OS here?

You will need RECONF for many libraries. And you cannot expect people to
ifdef RECONF for a few systems.
The best is to fix it once in the RECONF definition, not in every rules.mak.

With my kindest regards,

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list