[vlc-devel] [PATCH 1/4] decoder: Give packetizer aspect ratio to decoder.

[Martin Storsjö]

On Thu, 6 Feb 2014, Martin Storsjö wrote:

> From: Julian Scheel <julian at jusst.de>
>
> When the packetizer detects a valid pixel aspect ratio this should be
> forwarded to the decoders input format. This is helpful for decoder modules
> which do not expose the aspect ratio on their own.
>
> Signed-off-by: Julian Scheel <julian at jusst.de>
> ---
> IIRC the discussion last time ended at whether all of the struct
> should be copied, or just these fields. For this use case either
> is fine I think.
>
> Should these fields always be copied, or only the first time?
> As it currently is written, it disallows any updates of the
> aspect ratio through this channel.

I guess doing it like this (copying only the first time) is better than 
what we have right now, or should we always copy it, since it's just a 
hint to the decoder anyway?

> ---
> src/input/decoder.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/src/input/decoder.c b/src/input/decoder.c
> index d7caf2d..79a729d 100644
> --- a/src/input/decoder.c
> +++ b/src/input/decoder.c
> @@ -1569,6 +1569,21 @@ static void DecoderProcessVideo( decoder_t *p_dec, block_t *p_block, bool b_flus
>                 es_format_Clean( &p_dec->fmt_in );
>                 es_format_Copy( &p_dec->fmt_in, &p_packetizer->fmt_out );
>             }
> +
> +            /* If the packetizer provides aspect ratio information use it as
> +             * long as the decoder itself provides no aspect ratio
> +             * information. */

I amended this comment locally like this, to clarify that this doesn't 
overwrite anything anywhere but just touches the input format to the 
decoder, where most decoder don't use it in any way.

             /* If the packetizer provides aspect ratio information, pass it
              * to the decoder as a hint if the decoder itself can't provide
              * it. */

// Martin