[vlc-devel] [PATCH 1/4] decoder: Give packetizer aspect ratio to decoder.

[Martin Storsjö]

On Fri, 7 Feb 2014, Martin Storsjö wrote:

> On Thu, 6 Feb 2014, Martin Storsjö wrote:
>
>> From: Julian Scheel <julian at jusst.de>
>> 
>> When the packetizer detects a valid pixel aspect ratio this should be
>> forwarded to the decoders input format. This is helpful for decoder modules
>> which do not expose the aspect ratio on their own.
>> 
>> Signed-off-by: Julian Scheel <julian at jusst.de>
>> ---
>> IIRC the discussion last time ended at whether all of the struct
>> should be copied, or just these fields. For this use case either
>> is fine I think.
>> 
>> Should these fields always be copied, or only the first time?
>> As it currently is written, it disallows any updates of the
>> aspect ratio through this channel.
>
> I guess doing it like this (copying only the first time) is better than what 
> we have right now, or should we always copy it, since it's just a hint to the 
> decoder anyway?

Amended the patch locally to copy these fields every time, since they're 
only input hints to the decoder anyway.

Will push in a while if there's no more comments.

// Martin