[vlc-devel] [vlc-commits] vdpau/avcodec: fix build for older ffmpeg

[Rémi Denis-Courmont]

On Mon, 10 Feb 2014 15:26:27 +0100, Rafaël Carré <funman at videolan.org>
wrote:
> On 02/06/14 17:32, Rémi Denis-Courmont wrote:
>> On Thu, 6 Feb 2014 10:58:14 -0500, Tristan Matthews
>> <le.businessman at gmail.com> wrote:
>>> On Thu, Feb 6, 2014 at 3:36 AM, Rémi Denis-Courmont <remi at remlab.net>
>>> wrote:
>>>> On Wed,  5 Feb 2014 23:30:02 +0100 (CET), git at videolan.org (Tristan
>>>> Matthews) wrote:
>>>>> vlc | branch: master | Tristan Matthews <le.businessman at gmail.com> |
>> Wed
>>>>> Feb  5 16:51:28 2014 -0500|
[4e0240788000e30f7529fded04dbc281d5a8f91f]
>> |
>>>>> committer: Tristan Matthews
>>>>>
>>>>> vdpau/avcodec: fix build for older ffmpeg
>>>>
>>>> You are merging an *INCORRECT* patch that contradicts earleir
>>>> discussions.
>>>> Please remove this now or I will have to revert it.
>>>
>>> OK.
>>>
>>>> For the technical aspects, please refer to archives.
>>>
>>> I guess you mean
>>>
https://mailman.videolan.org/pipermail/vlc-devel/2013-April/092607.html
>>> etc.
>> 
>> Yes, that.
> 
> """
> Even if
> someone is willing to waste their time writing the tests, the
maintainance
> burden will still fall on the core VLC developers. This is unacceptable
to
> me.
> """

Those are not "the technical aspects".

> Well we (me and j-b?) are doing that already, I do not see why this
> patch should be removed while we use the same macro elsewhere in avcodec
code.

No offense intended, but neither j-b nor you, nor anybody has yet fully
worked around the versioning FFmpeg clusterfuck. It is still broken (and
mostly unfixable) in the configure script, in addition to the VDPAU plugin.

In any case the code remains broken as noted in the pert of the mail that
you cut out from the quote.

-- 
Rémi Denis-Courmont
Sent from my collocated server