[vlc-devel] [vlc-commits] vdpau/avcodec: fix build for older ffmpeg

[Rémi Denis-Courmont]

On Mon, 10 Feb 2014 16:15:03 +0100, Jean-Baptiste Kempf <jb at videolan.org>
wrote:
> On 10 Feb, Rémi Denis-Courmont wrote :
>> On Mon, 10 Feb 2014 16:01:27 +0100, Jean-Baptiste Kempf
<jb at videolan.org>
>> wrote:
>> > On 10 Feb, Rémi Denis-Courmont wrote :
>> >> No offense intended, but neither j-b nor you, nor anybody has yet
>> >> fully
>> >> worked around the versioning FFmpeg clusterfuck. It is still broken
>> (and
>> > 
>> > No offense taken. I do my best, but the task is daunting.
>> > 
>> >> mostly unfixable) in the configure script, in addition to the VDPAU
>> >> plugin.
>> > 
>> > An ugly workaround would be to disable VDPAU if micro > 100, aka
FFMpeg
>> > case.
>> 
>> IIRC, VDPAU is not the only place that checks for pkg-config version
>> numbers.
> 
> This is true, but so far, it has not bitten in our ass yet.
> 
> Yes, I have 2 contribs, one with libav, one with FFmpeg and I check
> regularly. ($deity bless ln -sf :D)

For contrib, it would be far less intrusive to patch the FFmpeg version
numbers back to corresponding libav numbers. But either way, a recent
FFmpeg build will probably always work - except for incompatible API
differences.

No, the problem lies with third party distributions using FFmpeg and
(also) leaving the broken version numbers. Then the problem is *not*
specific to VDPAU. It just depends on how old their FFmpeg is. But it is
the responsibility and conscious decision of the third parties in question,
so it is their problem to deal with. Not mine, not ours.

-- 
Rémi Denis-Courmont
Sent from my collocated server