[vlc-devel] [vlc-commits] vdpau/avcodec: fix build for older ffmpeg

[Rafaël Carré]

On 02/10/14 15:54, Rémi Denis-Courmont wrote:
> On Mon, 10 Feb 2014 15:26:27 +0100, Rafaël Carré <funman at videolan.org>
> wrote:
>> On 02/06/14 17:32, Rémi Denis-Courmont wrote:
>>> On Thu, 6 Feb 2014 10:58:14 -0500, Tristan Matthews
>>> <le.businessman at gmail.com> wrote:
>>>> On Thu, Feb 6, 2014 at 3:36 AM, Rémi Denis-Courmont <remi at remlab.net>
>>>> wrote:
>>>>> On Wed,  5 Feb 2014 23:30:02 +0100 (CET), git at videolan.org (Tristan
>>>>> Matthews) wrote:
>>>>>> vlc | branch: master | Tristan Matthews <le.businessman at gmail.com> |
>>> Wed
>>>>>> Feb  5 16:51:28 2014 -0500|
> [4e0240788000e30f7529fded04dbc281d5a8f91f]
>>> |
>>>>>> committer: Tristan Matthews
>>>>>>
>>>>>> vdpau/avcodec: fix build for older ffmpeg
>>>>>
>>>>> You are merging an *INCORRECT* patch that contradicts earleir
>>>>> discussions.
>>>>> Please remove this now or I will have to revert it.
>>>>
>>>> OK.
>>>>
>>>>> For the technical aspects, please refer to archives.
>>>>
>>>> I guess you mean
>>>>
> https://mailman.videolan.org/pipermail/vlc-devel/2013-April/092607.html
>>>> etc.
>>>
>>> Yes, that.
>>
>> """
>> Even if
>> someone is willing to waste their time writing the tests, the
> maintainance
>> burden will still fall on the core VLC developers. This is unacceptable
> to
>> me.
>> """
> 
> Those are not "the technical aspects".
> 
>> Well we (me and j-b?) are doing that already, I do not see why this
>> patch should be removed while we use the same macro elsewhere in avcodec
> code.
> 
> No offense intended, but neither j-b nor you, nor anybody has yet fully
> worked around the versioning FFmpeg clusterfuck. It is still broken (and
> mostly unfixable) in the configure script, in addition to the VDPAU plugin.

No offense taken, we are doing what we can given the indeed broken
situation.

> In any case the code remains broken as noted in the pert of the mail that
> you cut out from the quote.

Sorry but I don't see them.

Care to lay them out explicitely again?

As long as Libav micro version numbers do not go up to 100 our solution
is fine
inside individual c/h files.

configure.ac checks should use the lowest common version number.


For this specific change, even if not handling correctly all versions of
FFmpeg
and Libav wrt vdpau support it's still easing our pain with no adverse
effects.