[vlc-devel] [PATCH] Added hotkey for video transformation. Pressing Ctrl+Alt+r the user can navigate through the available transformation modes.

[Rémi Denis-Courmont]

On Tue, 11 Feb 2014 01:44:38 +0200, Stefanos Orovas
<stef.orovas at gmail.com>
wrote:
>>
> I tried but didn't get a result. Can you please provide me more info?

I cannot explain it any better.

>> +             config_PutPsz( p_intf, "transform-type", transform_type
);
>> > +             config_PutPsz( p_intf, "video-filter", psz_string );
>>
>> As pointed out previously, this would clobber the user configuration.
>> Please stick to var_*().
>>
> 
> I see in file modules/gui/qt4/components/extended_panels.cpp that the
> "transform-type" changes by using config_PutPsz() (when user selects it
> from the dropdown menu in settings) but you mentioned that i shouldn't
use
> this function. Why is it wrong to use it on the hotkey?

I told you already. It clobbers the configuration and will not work if
there is a command line parameter.

-- 
Rémi Denis-Courmont
Sent from my collocated server